Split documentation for navigation config #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bszwarc
requested review from
antiheld,
dariadomagala-sap,
hardl,
jesusreal,
kazydek,
klaudiagrz,
kwiatekus,
maxmarkus,
parostatkiem-zz,
pekura,
tomekpapiernik and
y-kkamil
as code owners
dariadomagala-sap
approved these changes
Jan 22, 2019
docs/navigation-configuration.md
Outdated
|
|
||
|
|
||
|  | ||
|  |
There was a problem hiding this comment.
Not sure if elements is a good word here. I kinda liked layout better :)
There was a problem hiding this comment.
I changed it back to layout :)
kazydek
reviewed
Jan 23, 2019
docs/navigation-configuration.md
Outdated
| 3. Main content window, where the micro front-end is rendered. | ||
| 1. Top navigation, which displays the main navigation path. | ||
| 2. Side navigation, which displays the defined applications. | ||
| 3. Main content window, which renders the micro frontend. |
There was a problem hiding this comment.
no, I'm gonna remove them.
kazydek
approved these changes
Jan 23, 2019
bszwarc
force-pushed
the
issue-276-docsplit
branch
from
9226f6d to
4bc4102
Compare
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
* Split documentation for navigation config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
See also #276