Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iframe top position #377

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Conversation

jesusreal
Copy link
Contributor

@jesusreal jesusreal commented Jan 22, 2019

Description

Changes proposed in this pull request:

  • Fix iframe top position (was 2 pixels below it should)

How to reproduce it
Please add this line to core/src/Backdrop.html, together with the other styles for .fd_overlay: background: rgba(74,80,92, .1);. The bug is evident only by using a different color
for the Luigi part backdrop.

@jesusreal jesusreal merged commit 861bf4e into SAP:master Jan 23, 2019
@jesusreal jesusreal deleted the fix-iframe-top-position branch March 13, 2019 10:29
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants