Implement test coverage feature #390
Conversation
parostatkiem-zz
requested review from
antiheld,
dariadomagala-sap,
hardl,
jesusreal,
JohannesDoberer,
kwiatekus,
marynaKhromova,
maxmarkus,
pekura and
y-kkamil
as code owners
|
Is there anything else other than |
|
Didn't work, the other |
|
I have managed to run nyc as a coverage reporter. It gives different output than your solution, though. I think we should investigate this further - where this difference comes from, which one is correct, and is there any added value for using nyc over old istanbul. |
|
@y-kkamil Looks like NYC is just a command line overlay for Istanbul so they seem to have common roots. I've got no idea what causes the coverage differences then 😆 IMO we can stick to my solution. As I said on daily, in the worst case that the alpha package fails, no customer/Luigi user will be harmed. We just won't be able to see test coverage, not a big deal... |
Description
Istanbulhasn't been officially updated for 2 years since 0.4.5 version came out. That version (the newest stable one) usesbabel-core 6.x.xand LuigiCore uses@babel/core ^7.0.0.Somehow it just can't run together in harmony, furthermore having 2 Babels would be confusing (at least). I've searched the whole Internet and everyone says the only solution is including an alpha version of
Istanbulwhich works really well (they say) and uses@babel/core."What about
test:watch?"It works as it did before. The report is generated after you end the watch process (ctrl+c).
No, there's no other solution. Istanbul collects data from the output of Mocha's test process. An output is generated at process' exit.
Although final changes are really small, this wasn't an easy task. I've tried everything I could to avoid alpha version of
Istanbul+ there were many more complications.Changes proposed in this pull request:
Istanbullib to generate test coverage reportRelated issue(s)