Reload same node fails if no iframe exists #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ec5f47c.
…nsaved-changes-modal # Conflicts: # core/src/services/routing.js
…nsaved-changes-modal
maxmarkus
requested review from
antiheld,
dariadomagala-sap,
hardl,
jesusreal,
JohannesDoberer,
kwiatekus,
marynaKhromova,
parostatkiem-zz,
pekura and
y-kkamil
as code owners
dariadomagala-sap
approved these changes
Feb 4, 2019
y-kkamil
approved these changes
Feb 4, 2019
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
* tets * Revert "tets" This reverts commit ec5f47c. * Modal interaction works * tets * Implement the prompt * Improve code & add comments * Add support for custom title and text * Fix obsolete import * Luigi client creates extra entry in browser navigation history - fix. * Handle potential errors * Add unit test * Add demo to Angular example & add e2e tests * Update comment in e2e * Undo temporary change * Remove unnecessary css imports * Add missing dependency * Remove unnecessary changes * Refactor state structure in app.html * extract checking if component is able to handle modal * shorten promise handling * Remove obsolete changes * Improve dirty page example in Angular app * Improve solution * Improve history handling * Fix typo * Add missing dependency * Improve e2e & use dedicated `data-cy` attribute * Remove unnecessary e2e comment * hash navigation in FF fix * context switcher on blur FF fix * do not show three dot menu on narrow screens if there is no displayable top nav node * top nav links from the three dots menu did not work properly - fix * - fix content rendering in edge browser - title vertical alignment fix * Remove obsolete comment * rename 'changeDirtyStatus' method & generate proper docu * Rename e2e tests * Polish the language * Remove unnecessary comment * Center the modal when side nav is collapsed * center the modal in the iframe * Improve modal responsiveness with side Nav * Remove unwanted history entry when user declines redirecting * Avoid unwanted history entry when redirecting * Remove unnecessary example from docu * Focus "Yes" button on modal * Improve modal positioning * typo in doc * Improve responsiveness * Update unsaved changes modal trigger to support external links on top and left nav * Support unsaved changes modal trigger on logout * Refactorings to minimize code duplication * Add error handler for showUnsavedChangesModal on handleRouteClick mehtod * For navigation from luigi client, apply unsaved changes logic without browser history manipulation * Avoid needing to click twice in the modal when clicking history back and then No in the modal * Fix unit tests * triggering iframe reload when the same route is accessed again * window path needs to be trimmed for path routing * be gracefully, sometimes, there is no spoon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check if a a iframe was found, to not trying to reload a non-existing iframe.