Improve login error behavior #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ks backswards compatibility check
# Conflicts: # client/package-lock.json # client/package.json # core/examples/luigi-sample-angular/package-lock.json # core/examples/luigi-sample-angular/package.json # core/package-lock.json # core/package.json # core/public/package.json
maxmarkus
requested review from
antiheld,
dariadomagala-sap,
hardl,
jesusreal,
JohannesDoberer,
kwiatekus,
marynaKhromova,
parostatkiem-zz,
pekura and
y-kkamil
as code owners
# Conflicts: # core/src/Alert.html
pekura
suggested changes
Mar 27, 2019
| }, 50); | ||
| }) | ||
| .catch(err => { | ||
| console.error(err); | ||
| reject(err); | ||
| localStorage.clear(); |
There was a problem hiding this comment.
- Is it not too harsch to clear the whole local storage? It would be more polite to just clear keys this auth provider handles.
- Do we clear auth data in non-error logout flows as well?
- Is there a reason to not use session storage for the auth data?
There was a problem hiding this comment.
Yes, you are right. We usually use localStorage.removeItem('luigi.auth'); upon errors and normal logout. I guess localStorage is used to be able to close the window and still be logged in without going trough sso flow.
There was a problem hiding this comment.
Please doublecheck with Philipp if he is fine with using localStorae here, thanks!
|
The logout page is not a beauty:
Can we improve that a bit? |
parostatkiem-zz
approved these changes
Mar 29, 2019
|
We have relied on localStorage so far, changing it to sessionStorage would be breaking change. Maybe we should add a config setting so the user can switch which storage method he wants to use. Should be done in separate ticket. |
pekura
approved these changes
Apr 1, 2019
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
improved oidc provider error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redirecting now to logout.html after token issues.
Could be tested in combination with https://github.com/kyma-project/console/pull/720