Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent unescaped characters in the Alert component #461

Merged
merged 3 commits into from
Apr 4, 2019
Merged

Prevent unescaped characters in the Alert component #461

merged 3 commits into from
Apr 4, 2019

Conversation

y-kkamil
Copy link

@y-kkamil y-kkamil commented Apr 3, 2019

Description

Changes proposed in this pull request:

  • Change lifecycle hook to prevent unescaped characters in the Alert component.

Related issue(s)
Fixes #447

@pekura pekura self-assigned this Apr 3, 2019
pekura
pekura suggested changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@pekura pekura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not work for alerts with links:

Bildschirmfoto 2019-04-03 um 14 12 50

@y-kkamil y-kkamil requested a review from pekura April 3, 2019 14:14
pekura
pekura suggested changes Apr 3, 2019
View reviewed changes
core/src/Alert.html Outdated Show resolved Hide resolved
@y-kkamil y-kkamil requested a review from pekura April 4, 2019 08:00
@JohannesDoberer JohannesDoberer self-assigned this Apr 4, 2019
@pekura pekura merged commit 5da4a1f into SAP:master Apr 4, 2019
@pekura pekura deleted the prevent-unescaped-characters-in-alert branch April 4, 2019 13:17
hardl referenced this pull request in hardl/luigi Apr 5, 2019
@hardl
m (#176)
17bf8be 
* Deactivate Typescript declaration file for Luigi Client (#466)

* Prevent unescaped characters in the Alert component (#461)

* ios scroll (#469)

* Prevent unlogged rendering (#451)

* Add ‘isHidden’ prop to Authorization component

* Render TopNav only if needed
@pekura pekura added area/luigi bug Something isn't working labels Apr 12, 2019
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@pekura
Prevent unescaped characters in the Alert component (SAP#461)
9fd07a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pekura pekura pekura approved these changes

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@antiheld antiheld Awaiting requested review from antiheld

@dariadomagala-sap dariadomagala-sap Awaiting requested review from dariadomagala-sap

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@jesusreal jesusreal Awaiting requested review from jesusreal

@kwiatekus kwiatekus Awaiting requested review from kwiatekus

@marynaKhromova marynaKhromova Awaiting requested review from marynaKhromova

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@parostatkiem-zz parostatkiem-zz Awaiting requested review from parostatkiem-zz

Assignees

@pekura pekura

@JohannesDoberer JohannesDoberer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unescaped character may appear in the Alert component
3 participants
@y-kkamil @pekura @JohannesDoberer