Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check origin of postmessage #468

Merged
merged 37 commits into from
Apr 11, 2019
Merged

Check origin of postmessage #468

merged 37 commits into from
Apr 11, 2019

Conversation

dariadomagala-sap
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Check origin of postmessage

Related issue(s)

@dariadomagala-sap dariadomagala-sap added WIP Work in progress area/luigi security/medium Related to CVSSv3 security rating https://www.first.org/cvss/calculator/3.0 labels Apr 4, 2019
@jesusreal jesusreal self-assigned this Apr 4, 2019
jesusreal
jesusreal reviewed Apr 4, 2019
View reviewed changes
Copy link
Contributor

@jesusreal jesusreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding my thoughts trying to help delivering this faster

core/src/App.html Show resolved Hide resolved
core/src/App.html Outdated Show resolved Hide resolved
core/src/App.html Outdated Show resolved Hide resolved
pekura
pekura reviewed Apr 5, 2019
View reviewed changes
core/src/App.html Outdated Show resolved Hide resolved
jesusreal
jesusreal suggested changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@jesusreal jesusreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comments

core/src/services/iframe.js Outdated Show resolved Hide resolved
core/src/App.html Outdated Show resolved Hide resolved
core/src/App.html Outdated Show resolved Hide resolved
core/src/App.html Show resolved Hide resolved
core/src/App.html Outdated Show resolved Hide resolved
core/examples/luigi-sample-angular/src/app/project/project.component.ts Show resolved Hide resolved
pekura
pekura suggested changes Apr 11, 2019
View reviewed changes
core/src/services/iframe.js Outdated Show resolved Hide resolved
core/src/services/iframe.js Show resolved Hide resolved
core/src/App.html Outdated Show resolved Hide resolved
core/src/App.html Outdated Show resolved Hide resolved
core/src/App.html Outdated Show resolved Hide resolved
jesusreal
jesusreal suggested changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@jesusreal jesusreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of possible issues and cosmetic changes

core/src/App.html Outdated Show resolved Hide resolved
core/src/services/iframe.js Outdated Show resolved Hide resolved
core/src/utilities/helpers/iframe-helpers.js Outdated Show resolved Hide resolved
core/src/App.html Outdated Show resolved Hide resolved
core/src/App.html Outdated Show resolved Hide resolved
core/src/App.html Outdated Show resolved Hide resolved
core/src/utilities/helpers/iframe-helpers.js Outdated Show resolved Hide resolved
core/src/utilities/helpers/iframe-helpers.js Outdated Show resolved Hide resolved
pekura
pekura approved these changes Apr 11, 2019
View reviewed changes
core/src/services/iframe.js Outdated Show resolved Hide resolved
core/src/services/iframe.js Outdated Show resolved Hide resolved
pekura
pekura suggested changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@pekura pekura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@jesusreal jesusreal merged commit 51dc1e4 into SAP:master Apr 11, 2019
@pekura pekura added the enhancement New feature or request label Apr 12, 2019
@hardl hardl added the security always set in addition to specific security severity label, since github filtering is lacking OR label Feb 11, 2020
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@dariadomagala-sap @jesusreal
Check origin of postmessage (SAP#468)
4512bd4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesusreal jesusreal jesusreal approved these changes

@pekura pekura pekura approved these changes

@antiheld antiheld Awaiting requested review from antiheld

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer JohannesDoberer is a code owner

@kwiatekus kwiatekus Awaiting requested review from kwiatekus

@marynaKhromova marynaKhromova Awaiting requested review from marynaKhromova

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@parostatkiem-zz parostatkiem-zz Awaiting requested review from parostatkiem-zz

@y-kkamil y-kkamil Awaiting requested review from y-kkamil

Assignees

@pekura pekura

Labels
enhancement New feature or request security/medium Related to CVSSv3 security rating https://www.first.org/cvss/calculator/3.0 security always set in addition to specific security severity label, since github filtering is lacking OR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dariadomagala-sap @pekura @jesusreal @hardl