Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix linter errors #482

Merged
merged 4 commits into from
Apr 15, 2019
Merged

fix linter errors #482

merged 4 commits into from
Apr 15, 2019

Conversation

maxmarkus
Copy link
Contributor

fixed linting errors for angular example

@maxmarkus maxmarkus added bug Something isn't working area/luigi labels Apr 15, 2019
@maxmarkus maxmarkus force-pushed the 481-fix-linter-errors branch from bbea51f to 4cc3092 Compare April 15, 2019 08:59
@maxmarkus maxmarkus added this to the Sprint_Swinka_12 milestone Apr 15, 2019
@marynaKhromova marynaKhromova self-assigned this Apr 15, 2019
@JohannesDoberer JohannesDoberer self-assigned this Apr 15, 2019
@jesusreal jesusreal self-assigned this Apr 15, 2019
marynaKhromova
marynaKhromova approved these changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@marynaKhromova marynaKhromova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

jesusreal
jesusreal approved these changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@jesusreal jesusreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jesusreal jesusreal merged commit e6b466a into SAP:master Apr 15, 2019
@jesusreal jesusreal deleted the 481-fix-linter-errors branch April 15, 2019 13:41
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@maxmarkus @jesusreal
Fix linter errors in angular example app (SAP#482)
a32dd02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesusreal jesusreal jesusreal approved these changes

@marynaKhromova marynaKhromova marynaKhromova approved these changes

@antiheld antiheld Awaiting requested review from antiheld

@dariadomagala-sap dariadomagala-sap Awaiting requested review from dariadomagala-sap

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer JohannesDoberer is a code owner

@kwiatekus kwiatekus Awaiting requested review from kwiatekus

@parostatkiem-zz parostatkiem-zz Awaiting requested review from parostatkiem-zz

@pekura pekura Awaiting requested review from pekura

@y-kkamil y-kkamil Awaiting requested review from y-kkamil

Assignees

@jesusreal jesusreal

@JohannesDoberer JohannesDoberer

@marynaKhromova marynaKhromova

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxmarkus @jesusreal @marynaKhromova @JohannesDoberer