Display info in bottom left corner #503
Conversation
parostatkiem-zz
requested review from
antiheld,
bszwarc,
dariadomagala-sap,
hardl,
jesusreal,
JohannesDoberer,
kazydek,
klaudiagrz,
kwiatekus,
marynaKhromova,
maxmarkus,
mmitoraj,
pekura,
tomekpapiernik and
y-kkamil
as code owners
docs/general-settings.md
Outdated
| @@ -20,3 +21,4 @@ settings: { | |||
| * **header.title** defines the top left navigation title. | |||
| * **header.favicon** defines the favicon. It rquires a standard favicon file with the `.ico` extension, and 16x16px or 32x32px dimensions. | |||
| * **responsiveNavigation** allows adding a button on the left side of the top navigation. Upon click, the button shows or hides the left navigation. The possible values are `simple` and `simpleMobileOnly`. `simple` displays the button regardless of the browser window´s size, while `simpleMobileOnly` shows the button when the width is lower than `600px`. If you don't specify any value for **responsiveNavigation**, the button will not be displayed. The same applies when you enable **hideSideNav** for the current active navigation node. | |||
| * **sideNavFooterText** a string that is displayed in a sticky footer inside Side Navigation. Good place to display the version of your application. | |||
There was a problem hiding this comment.
It can also be a function (not async) since we are using getConfigValue to fetch it. Do we want to mention this?
There was a problem hiding this comment.
Good point, I'll mention it.
There was a problem hiding this comment.
Sadly, it can't be. Checked with arrow and normal function.
core/src/navigation/LeftNav.html
Outdated
| @@ -291,4 +305,12 @@ | |||
| width: 1.25rem; | |||
| } | |||
| } | |||
|
|
|||
| .lui-sideNavFooter { | |||
| position: sticky; | |||
There was a problem hiding this comment.
fixed instead of sticky? It seems to be placed not at the end of the navbar.
There was a problem hiding this comment.
Reading the conversation on Slack about this, I understood it as sticky.
There was a problem hiding this comment.
... but looking at the Zeplin, it's fixed. I'm confused 😕
core/src/navigation/LeftNav.html
Outdated
| @@ -139,6 +139,13 @@ | |||
| {/if} {/each} | |||
| </nav> | |||
| {/if} | |||
| {#if isFooterVisible(footerText)} | |||
| <div class="lui-sideNavFooter fd-has-padding-small fd-has-type-minus-1"> | |||
| {#if footerText} | |||
There was a problem hiding this comment.
Do we need the container at all, if footerText is undefined? else I would put it before isFooterVisible.
There was a problem hiding this comment.
I did the implementation (this template + isFooterVisible function) with having the future placement of SideNav close button on mind. It's visible on Zeplin project. Lydia says it's a concept and likely be introduced in the future.
Furthermore, who knows - maybe we'll put there something else in the future?
In general, I'm against useless containers (!) but this is a special case in my opinion.
…isplay-info-in-bottom-left-corner
Co-Authored-By: Klaudia Grzondziel <[email protected]>
* Add sideNav footer with static text * Render the footer conditionaly & render the configurable text * add a new setting to luigi-config * update docu * Add e2e test * Add sticky footer behaviour * Display LuigiClient version in Angular example app * Update docs/general-settings.md Co-Authored-By: Klaudia Grzondziel <[email protected]>
Description
Changes proposed in this pull request:
and is stickyRelated issue(s)