Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup codeowners and contributing files #531

Merged

Conversation

jesusreal
Copy link
Contributor

@jesusreal jesusreal commented May 15, 2019

Description

Changes proposed in this pull request:

  • Update github issue templates where needed
  • Delete old unused github templates
  • Update CODEOWNERS file
  • Update CODE_OF_CONDUCT file
  • Update CONTRIBUTING file

@jesusreal jesusreal added the documentation documentation tasks label May 16, 2019
@maxmarkus maxmarkus self-assigned this May 20, 2019
CODEOWNERS Show resolved Hide resolved
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small comments

@JohannesDoberer JohannesDoberer self-assigned this May 21, 2019
Copy link
Contributor

@bszwarc bszwarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments :)

CODE_OF_CONDUCT.md Show resolved Hide resolved

This Code of Conduct is adapted from the Contributor Covenant
(http://contributor-covenant.org), version 1.2.0, available at
http://contributor-covenant.org/version/1/2/0/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
http://contributor-covenant.org/version/1/2/0/
[here](http://contributor-covenant.org/version/1/2/0/).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "available at here" correct or should be "available here"?

CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CODE_OF_CONDUCT.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bszwarc bszwarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some very minor fixes

CODE_OF_CONDUCT.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
jesusreal and others added 3 commits May 22, 2019 08:55
Co-Authored-By: Barbara Szwarc <[email protected]>
Co-Authored-By: Barbara Szwarc <[email protected]>
Co-Authored-By: Barbara Szwarc <[email protected]>
@jesusreal jesusreal merged commit 2fda679 into SAP:master May 22, 2019
@jesusreal jesusreal deleted the cleanup_codeowners_and_contributing_files branch May 29, 2019 11:38
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants