Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend luigi core api by methods for getting important dom elements #544

Merged
merged 15 commits into from
Jun 3, 2019
Merged

Extend luigi core api by methods for getting important dom elements #544

merged 15 commits into from
Jun 3, 2019

Conversation

marynaKhromova
Copy link
Contributor

Proposed changes:

  • add methods to get:
    • currently active microfrontend iframe
    • all microfrontend iframes
    • shellbar component
    • top-right shellbar-actions component
  • write documentation for new functions

@marynaKhromova marynaKhromova added this to the Sprint_0 milestone May 22, 2019
@marynaKhromova marynaKhromova added the enhancement New feature or request label May 22, 2019
@maxmarkus maxmarkus self-assigned this May 23, 2019
maxmarkus
maxmarkus suggested changes May 23, 2019
View reviewed changes
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments :)

core/package.json Outdated Show resolved Hide resolved
core/package.json Show resolved Hide resolved
@JohannesDoberer JohannesDoberer self-assigned this May 27, 2019
@JohannesDoberer JohannesDoberer mentioned this pull request May 27, 2019
Closed
@marynaKhromova marynaKhromova added the documentation documentation tasks label May 29, 2019
@marynaKhromova
Copy link
Contributor Author

@bszwarc Would be great if you can quickly take a look at dom-elements.js. Thanks :)

bszwarc
bszwarc suggested changes May 31, 2019
View reviewed changes
Copy link
Contributor

@bszwarc bszwarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added my comments :)

core/src/core-api/dom-elements.js Outdated Show resolved Hide resolved
core/src/core-api/dom-elements.js Outdated Show resolved Hide resolved
core/src/core-api/dom-elements.js Outdated Show resolved Hide resolved
core/src/core-api/dom-elements.js Outdated Show resolved Hide resolved
core/src/core-api/dom-elements.js Outdated Show resolved Hide resolved
core/src/core-api/dom-elements.js Outdated Show resolved Hide resolved
@marynaKhromova marynaKhromova merged commit 76efd22 into SAP:master Jun 3, 2019
@marynaKhromova marynaKhromova deleted the extend-luigi-core-api-for-getting-dom-elements branch June 4, 2019 08:49
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@marynaKhromova
Extend luigi core api by methods for getting important dom elements (S…
0349620 
…AP#544)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxmarkus maxmarkus maxmarkus approved these changes

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@bszwarc bszwarc bszwarc approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@jesusreal jesusreal Awaiting requested review from jesusreal

@pekura pekura Awaiting requested review from pekura

Assignees

@maxmarkus maxmarkus

@JohannesDoberer JohannesDoberer

Labels
documentation documentation tasks enhancement New feature or request
Projects
None yet
Milestone
Sprint_0
Development

Successfully merging this pull request may close these issues.
4 participants
@marynaKhromova @maxmarkus @JohannesDoberer @bszwarc