Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On auth expire soon event #545

Merged
merged 21 commits into from
Jun 5, 2019
Merged

On auth expire soon event #545

merged 21 commits into from
Jun 5, 2019

Conversation

JohannesDoberer
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 22, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@JohannesDoberer JohannesDoberer added WIP Work in progress enhancement New feature or request labels May 22, 2019
@maxmarkus maxmarkus added this to the Sprint_0 milestone May 23, 2019
@JohannesDoberer JohannesDoberer removed the WIP Work in progress label May 23, 2019
bszwarc
bszwarc suggested changes May 23, 2019
View reviewed changes
docs/authorization-events.md Outdated Show resolved Hide resolved
docs/authorization-configuration.md Outdated Show resolved Hide resolved
docs/authorization-configuration.md Outdated Show resolved Hide resolved
@jesusreal jesusreal self-assigned this May 24, 2019
jesusreal
jesusreal suggested changes May 24, 2019
View reviewed changes
Copy link
Contributor

@jesusreal jesusreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments below.

docs/authorization-configuration.md Show resolved Hide resolved
docs/authorization-configuration.md Outdated Show resolved Hide resolved
docs/authorization-events.md Outdated Show resolved Hide resolved
docs/authorization-configuration.md Outdated Show resolved Hide resolved
core/src/providers/auth/oAuth2ImplicitGrant.js Outdated Show resolved Hide resolved
core/src/providers/auth/oAuth2ImplicitGrant.js Outdated Show resolved Hide resolved
core/src/providers/auth/oAuth2ImplicitGrant.js Outdated Show resolved Hide resolved
core/src/providers/auth/oAuth2ImplicitGrant.js Outdated Show resolved Hide resolved
core/src/providers/auth/openIdConnect.js Show resolved Hide resolved
core/examples/luigi-sample-angular/src/luigi-config/extended/auth.js Show resolved Hide resolved
@JohannesDoberer JohannesDoberer requested a review from jesusreal May 27, 2019 14:17
jesusreal
jesusreal approved these changes May 27, 2019
View reviewed changes
Copy link
Contributor

@jesusreal jesusreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@marynaKhromova marynaKhromova self-assigned this May 28, 2019
marynaKhromova
marynaKhromova suggested changes May 28, 2019
View reviewed changes
Copy link
Contributor

@marynaKhromova marynaKhromova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) Only 2 tiny comments.

core/src/providers/auth/oAuth2ImplicitGrant.js Outdated Show resolved Hide resolved
docs/authorization-events.md Outdated Show resolved Hide resolved
bszwarc
bszwarc reviewed May 29, 2019
View reviewed changes
Copy link
Contributor

@bszwarc bszwarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

docs/authorization-events.md Outdated Show resolved Hide resolved
docs/authorization-events.md Outdated Show resolved Hide resolved
@jesusreal jesusreal merged commit e255387 into SAP:master Jun 5, 2019
@JohannesDoberer JohannesDoberer deleted the onAuthExpireSoon-event branch June 18, 2019 10:55
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@JohannesDoberer @jesusreal
On auth expire soon event (SAP#545)
da72a0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesusreal jesusreal jesusreal approved these changes

@bszwarc bszwarc bszwarc approved these changes

@marynaKhromova marynaKhromova marynaKhromova approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@pekura pekura Awaiting requested review from pekura

@kazydek kazydek Awaiting requested review from kazydek

@tomekpapiernik tomekpapiernik Awaiting requested review from tomekpapiernik

Assignees

@jesusreal jesusreal

@marynaKhromova marynaKhromova

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint_0
Development

Successfully merging this pull request may close these issues.
6 participants
@JohannesDoberer @CLAassistant @jesusreal @bszwarc @marynaKhromova @maxmarkus