Improve control over luigi bootstrap process #552
Conversation
# Conflicts: # core/src/core-api/config.js
pekura
requested review from
hardl,
jesusreal,
JohannesDoberer,
marynaKhromova and
maxmarkus
as code owners
|
With Luigi.setConfig() the Luigi app can now tell Luigi that configuration has been changed. This leads to updating of:
If other parts of Luigi needs to be updateable in runtime we should create dedicated issues for it. |
| items: configProfileNav.items || [] | ||
| }; | ||
| this.set({ profileNav: profileNavData }); | ||
| if (!this.get().navProfileListenerInstalled) { |
There was a problem hiding this comment.
Added this if block to avoid doOnStoreChange to be executed more than once.
| fn({ | ||
| current: store.get(), | ||
| changed: { config: true }, | ||
| previous: store.get() |
There was a problem hiding this comment.
It looks like current and previous is always the same, is this intentionally (for initial values?)?
There was a problem hiding this comment.
Yes this is on purpose, we just want to trigger the function there.
core/examples/luigi-sample-angular/src/luigi-config/extended/helpers.js
Outdated
Show resolved
Hide resolved
core/examples/luigi-sample-angular/src/luigi-config/extended/navigation.js
Show resolved
Hide resolved
…ver-luigi-bootstrap-process
…ver-luigi-bootstrap-process # Conflicts: # core/src/core-api/config.js
There was a problem hiding this comment.
Good job! 👍 I left only a couple of comments.
I've noticed as well a weird behavior when you cklick Add backdrop button.
Here are the steps to reproduce the issue:
- go to Projects - > Project One
- click
Add backdropbutton (nothing happens) - go to
Keep Selected Examplefrom the side navigation - you will see the overlay on the side navigation
And about documentation. Should it be done within this task or will we have the following task for it?
core/examples/luigi-sample-angular/e2e/tests/product-switcher.spec.js
Outdated
Show resolved
Hide resolved
|
Bug with backdrop modal is fixed. Documentation will be written in a follow up task. @marynaKhromova please check again. |
Great, thank you 👍 |
No description provided.