Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

577 close modals by esc-key #585

Merged
merged 4 commits into from
Jun 24, 2019
Merged

577 close modals by esc-key #585

merged 4 commits into from
Jun 24, 2019

Conversation

JohannesDoberer
Copy link
Contributor

No description provided.

@JohannesDoberer JohannesDoberer added this to the Sprint_1 milestone Jun 14, 2019
@JohannesDoberer JohannesDoberer added the enhancement New feature or request label Jun 14, 2019
@pekura pekura self-assigned this Jun 17, 2019
pekura
pekura suggested changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@pekura pekura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! An e2e test case for closing a modal with the ESC key would be very nice though!

@jesusreal jesusreal self-assigned this Jun 21, 2019
jesusreal
jesusreal approved these changes Jun 21, 2019
View reviewed changes
Copy link
Contributor

@jesusreal jesusreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@JohannesDoberer JohannesDoberer merged commit 65c19e2 into SAP:master Jun 24, 2019
@JohannesDoberer JohannesDoberer deleted the 577-close-modals-by-key branch July 16, 2019 05:48
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@JohannesDoberer
577 close modals by esc-key (SAP#585)
a2a07e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesusreal jesusreal jesusreal approved these changes

@pekura pekura pekura approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@marynaKhromova marynaKhromova Awaiting requested review from marynaKhromova

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

Assignees

@jesusreal jesusreal

@pekura pekura

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint_1
Development

Successfully merging this pull request may close these issues.
3 participants
@JohannesDoberer @jesusreal @pekura