Add goBack support for normal navigation #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxmarkus
requested review from
hardl,
jesusreal,
JohannesDoberer,
marynaKhromova and
pekura
as code owners
JohannesDoberer
approved these changes
Jun 24, 2019
pekura
approved these changes
Jun 24, 2019
…gi into 265-goback-internal-routes
maxmarkus
requested review from
bszwarc,
kazydek,
mmitoraj and
tomekpapiernik
as code owners
bszwarc
suggested changes
Jun 27, 2019
client/luigi-client.d.ts
Outdated
| @@ -136,8 +136,8 @@ export declare interface LinkManager { | |||
| fromContext: (navigationContext: string) => this; | |||
|
|
|||
| /** | |||
| * Discards the active view and navigates back to the last visited view (preserved view), if a preserved view was set before. | |||
| * @param {any} goBackValue data that is passed in the `goBackContext` field to the last visited view | |||
| * Discards the active view and navigates back to the last visited view. Works with preserved views, as well as classical browser back substitute. `goBackContext` is only available when using preserved views. | |||
There was a problem hiding this comment.
Suggested change
| * Discards the active view and navigates back to the last visited view. Works with preserved views, as well as classical browser back substitute. `goBackContext` is only available when using preserved views. | |
| * Discards the active view and navigates back to the last visited view. Works with preserved views, as well as the classic browser back substitute. **goBackContext** is only available when using preserved views. |
client/src/linkManager.js
Outdated
| @@ -206,22 +206,20 @@ export class linkManager extends LuigiClientBase { | |||
| } | |||
|
|
|||
| /** | |||
| * Discards the active view and navigates back to the last visited view (preserved view), if a preserved view was set before. | |||
| * Discards the active view and navigates back to the last visited view. Works with preserved views, as well as classical browser back substitute. `goBackContext` is only available when using preserved views. | |||
There was a problem hiding this comment.
Suggested change
| * Discards the active view and navigates back to the last visited view. Works with preserved views, as well as classical browser back substitute. `goBackContext` is only available when using preserved views. | |
| * Discards the active view and navigates back to the last visited view. Works with preserved views, as well as the classic browser back substitute. **goBackContext** is only available when using preserved views. |
docs/luigi-client-api.md
Outdated
| @@ -192,11 +192,11 @@ Returns **[boolean](https://developer.mozilla.org/docs/Web/JavaScript/Reference/ | |||
|
|
|||
| ### goBack | |||
|
|
|||
| Discards the active view and navigates back to the last visited view (preserved view), if a preserved view was set before. | |||
| Discards the active view and navigates back to the last visited view. Works with preserved views, as well as classical browser back substitute. `goBackContext` is only available when using preserved views. | |||
There was a problem hiding this comment.
Suggested change
| Discards the active view and navigates back to the last visited view. Works with preserved views, as well as classical browser back substitute. `goBackContext` is only available when using preserved views. | |
| Discards the active view and navigates back to the last visited view. Works with preserved views, as well as the classic browser back substitute. **goBackContext** is only available when using preserved views. |
Co-Authored-By: Barbara Szwarc <[email protected]>
bszwarc
approved these changes
Jun 27, 2019
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
* Implemented goBack to do history.back() if no preserved view is available * documented that goBackContext is only available when using preserved views * added warning when using goBackContext but its not available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goBack works now also if you are navigating normally and want to go back to the last route.