Dropdown functionality for top right nav nodes #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohannesDoberer
requested review from
bszwarc,
hardl,
jesusreal,
kazydek,
marynaKhromova,
maxmarkus,
mmitoraj,
pekura and
tomekpapiernik
as code owners
pekura
approved these changes
Jul 1, 2019
maxmarkus
changed the title
maxmarkus
suggested changes
Jul 1, 2019
To keep labels aligned
maxmarkus
approved these changes
Jul 1, 2019
bszwarc
suggested changes
Jul 2, 2019
docs/navigation-configuration.md
Outdated
| @@ -27,6 +27,9 @@ A navigation path is any existing path in the navigation tree. It connects the f | |||
|
|
|||
| If you set the **hideSideNav** property to `true`, the left navigation disappears when you click the affected node. It is set to `false` by default. | |||
|
|
|||
| If you want to group some navigation nodes and seperate these nodes into one parent node you can use the **category** property. The grouped navigation nodes are rendered in a dropdown. The **category** property should have a **label** and an **icon**. | |||
There was a problem hiding this comment.
Suggested change
| If you want to group some navigation nodes and seperate these nodes into one parent node you can use the **category** property. The grouped navigation nodes are rendered in a dropdown. The **category** property should have a **label** and an **icon**. | |
| If you want to group some navigation nodes into a separate parent node, you can use the **category** property. The grouped navigation nodes are rendered in a dropdown. The **category** property needs a **label** and an **icon**. |
…github.com:JohannesDoberer/luigi into 574-dropdown-functionality-for-top-right-nav-nodes
bszwarc
approved these changes
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.