Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the general settings docu #621

Merged
merged 5 commits into from
Jul 4, 2019
Merged

Update the general settings docu #621

merged 5 commits into from
Jul 4, 2019

Conversation

bszwarc
Copy link
Contributor

@bszwarc bszwarc commented Jul 1, 2019

Description

Changes proposed in this pull request:

  • Rework the responsiveNavigation parameter description
  • Added semiCollapsible value.
  • ...

Related issue(s)
See also #453

@bszwarc bszwarc added the documentation documentation tasks label Jul 1, 2019
@bszwarc bszwarc added this to the Sprint_1 milestone Jul 1, 2019
@bszwarc bszwarc requested a review from marynaKhromova July 1, 2019 09:06
mmitoraj
mmitoraj suggested changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@mmitoraj mmitoraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had a few minor suggestions :)

docs/general-settings.md Outdated Show resolved Hide resolved
docs/general-settings.md Outdated Show resolved Hide resolved
docs/general-settings.md Outdated Show resolved Hide resolved
docs/general-settings.md Outdated Show resolved Hide resolved
@maxmarkus maxmarkus removed this from the Sprint_1 milestone Jul 1, 2019
@maxmarkus maxmarkus self-assigned this Jul 1, 2019
@jesusreal jesusreal self-assigned this Jul 2, 2019
jesusreal
jesusreal suggested changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@jesusreal jesusreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, please check its validity

docs/general-settings.md Outdated Show resolved Hide resolved
@bszwarc
Copy link
Contributor Author

bszwarc commented Jul 3, 2019

I updated the description - I think in the overall description of the parameter we may include the buttons as examples, and when we describe the values - we can add more precise infos on where the buttons are located. It will be a bit easier to maintain when / if we have more settings. What do you think? 🤔

@jesusreal
Copy link
Contributor

Hi @bszwarc, it looks good to me after your changes, so I am approving this pr. If you want to further discuss what you stated in your last comments please let me know.

@hardl hardl merged commit ade6560 into SAP:master Jul 4, 2019
@bszwarc bszwarc deleted the issue-453 branch July 4, 2019 13:14
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@bszwarc @hardl
Update the general settings docu (SAP#621)
a21592a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxmarkus maxmarkus maxmarkus approved these changes

@jesusreal jesusreal jesusreal approved these changes

@mmitoraj mmitoraj mmitoraj approved these changes

@kazydek kazydek Awaiting requested review from kazydek

@tomekpapiernik tomekpapiernik Awaiting requested review from tomekpapiernik

@marynaKhromova marynaKhromova Awaiting requested review from marynaKhromova

Assignees

@maxmarkus maxmarkus

@jesusreal jesusreal

Labels
documentation documentation tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bszwarc @jesusreal @maxmarkus @mmitoraj @hardl