Node category documentation #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
maxmarkus
requested review from
bszwarc,
kazydek,
mmitoraj and
tomekpapiernik
as code owners
| category: { | ||
| label: 'General', | ||
| icon: 'general' | ||
| }, |
There was a problem hiding this comment.
Maybe a comment with an 'or'?
category: {
label: 'General',
icon: 'general'
},//OR
category: 'General'
There was a problem hiding this comment.
Yea, also thought about this, but we didn't have such case until now. Will add one
jesusreal
suggested changes
Jul 2, 2019
Co-Authored-By: Jesús Real Serrano <[email protected]>
…nto 615-docu-category-node
jesusreal
approved these changes
Jul 3, 2019
JohannesDoberer
approved these changes
Jul 3, 2019
Co-Authored-By: Barbara Szwarc <[email protected]>
bszwarc
reviewed
Jul 4, 2019
Co-Authored-By: Barbara Szwarc <[email protected]>
bszwarc
approved these changes
Jul 4, 2019
Co-Authored-By: Barbara Szwarc <[email protected]>
bszwarc
approved these changes
Jul 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing docu for node category configuration documentation.