-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
product switcher header to fiori3 concept #669
product switcher header to fiori3 concept #669
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I've refactored a bit styles and html. Let me know if it looks fine for you as well :)
I left only one small question. Check it below.
core/examples/luigi-sample-angular/e2e/tests/context-switcher.spec.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added my comments.
…ithub.com:JohannesDoberer/luigi into change-product-switcher-header-to-fiori3-concept-
…ithub.com:JohannesDoberer/luigi into change-product-switcher-header-to-fiori3-concept-
No description provided.