Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open split view in collapsed state #690

Merged
merged 29 commits into from
Aug 2, 2019

Conversation

maxmarkus
Copy link
Contributor

Added support for initial collapsed state

Copy link
Contributor

@marynaKhromova marynaKhromova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some small comments. Please check them below :)

Also, I have again the problem with scrolling on iOS in the split view.

And the mobile view needs small adjustment for semicollapsed left navigation mode.
Image from iOS (1)

core/src/services/split-view.js Outdated Show resolved Hide resolved
client/src/linkManager.js Show resolved Hide resolved
client/luigi-client.d.ts Show resolved Hide resolved
@JohannesDoberer JohannesDoberer self-assigned this Jul 31, 2019
Copy link
Contributor

@marynaKhromova marynaKhromova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maxmarkus maxmarkus added the documentation documentation tasks label Aug 1, 2019
@maxmarkus maxmarkus merged commit a332bcf into SAP:master Aug 2, 2019
@maxmarkus maxmarkus deleted the 687-open-collapsed-split-view branch August 2, 2019 09:51
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation tasks follow up Follow up tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants