Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback documentation for LuigiClient.addInitListener #697

Merged
merged 29 commits into from
Aug 6, 2019

Conversation

maxmarkus
Copy link
Contributor

Added documentation for LuigiClient.addInitListener callback documentation.

# Conflicts:
#	docs/luigi-client-api.md
…nts-docu

# Conflicts:
#	website/landingpage/public/styles.css
No clue what was the conflict, as those are all new files.
@JohannesDoberer JohannesDoberer self-assigned this Aug 1, 2019
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jesusreal jesusreal assigned jesusreal and unassigned maxmarkus Aug 2, 2019
Copy link
Contributor

@jesusreal jesusreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added my comments

client/src/lifecycleManager.js Outdated Show resolved Hide resolved
website/landingpage/public/styles.css Outdated Show resolved Hide resolved
client/src/lifecycleManager.js Show resolved Hide resolved
@maxmarkus maxmarkus merged commit eb1d091 into SAP:master Aug 6, 2019
@maxmarkus maxmarkus deleted the 682-initfn-arguments-docu branch August 6, 2019 11:12
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants