Add luigi bootstrap dom element option #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md
maxmarkus
reviewed
Jul 31, 2019
jesusreal
requested review from
bszwarc,
hardl,
JohannesDoberer,
kazydek,
marynaKhromova,
mmitoraj,
pekura and
tomekpapiernik
as code owners
marynaKhromova
suggested changes
Jul 31, 2019
maxmarkus
reviewed
Aug 1, 2019
maxmarkus
approved these changes
Aug 1, 2019
mmitoraj
suggested changes
Aug 1, 2019
| @@ -13,10 +13,10 @@ Set up and configure the main application. | |||
| * [Authorization events](authorization-events.md) guides you through the event configuration to react to Luigi authorization events. | |||
There was a problem hiding this comment.
Suggested change
| * [Authorization events](authorization-events.md) guides you through the event configuration to react to Luigi authorization events. | |
| * [Authorization events](authorization-events.md) guide you through the event configuration to react to Luigi authorization events. |
There was a problem hiding this comment.
it refers to the file, not to the events themshelves, therefore I would not apply the change.
docs/README.md
Outdated
| @@ -13,10 +13,10 @@ Set up and configure the main application. | |||
| * [Authorization events](authorization-events.md) guides you through the event configuration to react to Luigi authorization events. | |||
| * [General settings](general-settings.md) provides you with additional configuration parameters for Luigi. | |||
| * [Core API](luigi-core-api.md) provides you with API features that help you enrich and use Luigi Core. | |||
| * [Luigi UI features](luigi-ux-features.md) explains the different possibilities to customize some of the UI components that Luigi offers. | |||
There was a problem hiding this comment.
Suggested change
| * [Luigi UI features](luigi-ux-features.md) explains the different possibilities to customize some of the UI components that Luigi offers. | |
| * [Luigi UI features](luigi-ux-features.md) provide different possibilities of customizing some of the Luigi UI components. |
There was a problem hiding this comment.
I will commit your suggestion, but will use "provides" instead of "provide", since it refers to the file, no to the features themselves
Co-Authored-By: Małgorzata Świeca <[email protected]>
Co-Authored-By: Małgorzata Świeca <[email protected]>
Co-Authored-By: Małgorzata Świeca <[email protected]>
Co-Authored-By: Małgorzata Świeca <[email protected]>
Co-Authored-By: Małgorzata Świeca <[email protected]>
mmitoraj
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)