Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom events for core client communication #746

Merged
merged 49 commits into from
Aug 29, 2019
Merged

Custom events for core client communication #746

merged 49 commits into from
Aug 29, 2019

Conversation

maxmarkus
Copy link
Contributor

No description provided.

jesusreal and others added 15 commits August 5, 2019 17:14
@jesusreal
First version of custom events sent from client to core
7176583
@jesusreal
Merge remote-tracking branch 'upstream/master' into Custom-events-for…
11747b3 
…-core-client-communication

# Conflicts:
#	docs/luigi-client-api.md
@jesusreal
Simplify code for data structure sent from Client to Core
a9f2ef4
@jesusreal
Add logic for Luigi Client to listen to custom events
2ab8265
@jesusreal
Add Logic for core api to retrieve mf objects and send message to mf
955a05a
@jesusreal
Make custom events functionality work on both directions + renamings
c00ecf0
@jesusreal
Npm script for Luigi Core api microfrontends docu
5761a6e
@jesusreal
Minor improvements during handover
3b262e6
@maxmarkus
added currentNode to iframe.luigi instead of only clientPermissions f…
80b5595 
…or reuse with custom events
@maxmarkus
Merge remote-tracking branch 'upstream/master' into Custom-events-for…
fa520c8 
…-core-client-communication
@maxmarkus
docu udpates
f4d7d03
@maxmarkus
updated check to properly treat viewGroups
476565a
@maxmarkus
updated unit tests for getMicrofrontends
0adc8ba
@maxmarkus
excluded providers from istanbul
ea56977
@maxmarkus
ignore ios specific test
caea10e
@maxmarkus maxmarkus added the enhancement New feature or request label Aug 14, 2019
@JohannesDoberer JohannesDoberer self-assigned this Aug 19, 2019
@pekura pekura self-assigned this Aug 19, 2019
pekura
pekura approved these changes Aug 27, 2019
View reviewed changes
client/src/lifecycleManager.js Outdated Show resolved Hide resolved
client/luigi-client.d.ts Outdated Show resolved Hide resolved
bszwarc
bszwarc suggested changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@bszwarc bszwarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added review

docs/navigation-parameters-reference.md Outdated Show resolved Hide resolved
client/luigi-client.d.ts Outdated Show resolved Hide resolved
client/luigi-client.d.ts Outdated Show resolved Hide resolved
client/luigi-client.d.ts Outdated Show resolved Hide resolved
client/luigi-client.d.ts Outdated Show resolved Hide resolved
core/src/core-api/custom-messages.js Outdated Show resolved Hide resolved
core/src/core-api/dom-elements.js Outdated Show resolved Hide resolved
core/src/core-api/custom-messages.js Outdated Show resolved Hide resolved
client/src/lifecycleManager.js Outdated Show resolved Hide resolved
client/src/lifecycleManager.js Outdated Show resolved Hide resolved
@jesusreal jesusreal requested a review from bszwarc August 27, 2019 12:05
bszwarc
bszwarc suggested changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@bszwarc bszwarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments

docs/communication.md Outdated Show resolved Hide resolved
docs/communication.md Outdated Show resolved Hide resolved
docs/communication.md Outdated Show resolved Hide resolved
docs/communication.md Outdated Show resolved Hide resolved
docs/communication.md Outdated Show resolved Hide resolved
docs/communication.md Outdated Show resolved Hide resolved
docs/communication.md Outdated Show resolved Hide resolved
docs/communication.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/communication.md Outdated Show resolved Hide resolved
@jesusreal jesusreal merged commit c70cea0 into SAP:master Aug 29, 2019
@jesusreal jesusreal deleted the 674-custom-events-for-core-client-communication branch August 29, 2019 10:13
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@maxmarkus @jesusreal
Custom messages for Core and Client communication (SAP#746)
a748a16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pekura pekura pekura approved these changes

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@bszwarc bszwarc bszwarc approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@jesusreal jesusreal Awaiting requested review from jesusreal

@kazydek kazydek Awaiting requested review from kazydek

@marynaKhromova marynaKhromova Awaiting requested review from marynaKhromova

@mmitoraj mmitoraj Awaiting requested review from mmitoraj

@tomekpapiernik tomekpapiernik Awaiting requested review from tomekpapiernik

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

Assignees

@pekura pekura

@JohannesDoberer JohannesDoberer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maxmarkus @jesusreal @pekura @JohannesDoberer @bszwarc