luigiAfterInit lifecycle hook + app loading indicator #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxmarkus
requested review from
alexandra-simeonova,
bszwarc,
hardl,
jesusreal,
JohannesDoberer,
kazydek,
marynaKhromova,
mmitoraj,
pekura and
tomekpapiernik
as code owners
…oading-indicator # Conflicts: # client/src/lifecycleManager.js # client/src/luigi-client.js # docs/luigi-client-api.md
This reverts commit 8c9caca.
alexandra-simeonova
suggested changes
Sep 6, 2019
Co-Authored-By: Alexandra Simeonova <[email protected]>
Co-Authored-By: Alexandra Simeonova <[email protected]>
Co-Authored-By: Alexandra Simeonova <[email protected]>
Co-Authored-By: Alexandra Simeonova <[email protected]>
pekura
reviewed
Sep 6, 2019
| * @since 0.6.4 | ||
| */ | ||
| hideAppLoadingIndicator() { | ||
| const appLoadingIndicator = document.querySelector( |
There was a problem hiding this comment.
Why don't we just render the loading spinner and overlay in the place where luigi itself is rendered?
There was a problem hiding this comment.
Because Luigi itself is not rendered yet when we already show the loading spinner. We would need to create and set the spinner programmatically, which might take a while under some circumstances - we had it in place initially, but Philipp wanted to have it the way it is implemented now - simplification.
There was a problem hiding this comment.
At least we are consistent with the naming luigi-app-* selectors.
…kus/luigi into 757-initial-app-loading-indicator
pekura
approved these changes
Sep 8, 2019
alexandra-simeonova
approved these changes
Sep 9, 2019
…kus/luigi into 757-initial-app-loading-indicator
zarkosimic
approved these changes
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Luigi.ux().hideAppLoadingIndicator()luigiAfterInitlifecycle hook.