Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set userinfo without auth, new navigation.profile.staticUserInfoFn #832

Merged
merged 14 commits into from
Oct 1, 2019

Conversation

maxmarkus
Copy link
Contributor

Added navigation.profile.staticUserInfoFn setting which allows to set a static or async function to retrieve and return an object with name and email properties.

You can test it by disabling the use = "mockAuth" line in luigi-config/extended/ auth.js and defining your settings in navigation.js profile configuration.

Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 !

@alexandra-simeonova alexandra-simeonova self-assigned this Sep 18, 2019
@marynaKhromova marynaKhromova self-assigned this Sep 19, 2019
Copy link
Contributor

@marynaKhromova marynaKhromova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@JohannesDoberer JohannesDoberer merged commit 2b2a832 into SAP:master Oct 1, 2019
@maxmarkus maxmarkus deleted the 807-set-userinfo-without-auth branch December 6, 2019 11:40
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants