Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary files from public folder #84

Merged
merged 4 commits into from
Sep 20, 2018
Merged

Remove unnecessary files from public folder #84

merged 4 commits into from
Sep 20, 2018

Conversation

dariadomagala-sap
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Remove unnecessary files from public folder

@dariadomagala-sap dariadomagala-sap requested a review from a user September 14, 2018 11:48
@dariadomagala-sap dariadomagala-sap added the enhancement New feature or request label Sep 14, 2018
@jesusreal jesusreal self-assigned this Sep 18, 2018
jesusreal
jesusreal approved these changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@jesusreal jesusreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We will generate fonts folder on build pipeline in scope of #88

@kwiatekus kwiatekus merged commit a18e848 into SAP:master Sep 20, 2018
@kwiatekus kwiatekus deleted the clean-up-public-folder branch September 20, 2018 09:33
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@dariadomagala-sap @kwiatekus
Remove unneccesary files from public folder (SAP#84)
b455f5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesusreal jesusreal jesusreal approved these changes

@klaudiagrz klaudiagrz klaudiagrz approved these changes

@antiheld antiheld Awaiting requested review from antiheld

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@kazydek kazydek Awaiting requested review from kazydek

@kwiatekus kwiatekus Awaiting requested review from kwiatekus

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@pekura pekura Awaiting requested review from pekura

@tomekpapiernik tomekpapiernik Awaiting requested review from tomekpapiernik

@y-kkamil y-kkamil Awaiting requested review from y-kkamil

Assignees

@jesusreal jesusreal

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dariadomagala-sap @jesusreal @klaudiagrz @kwiatekus