improve authorization configuration #866
Conversation
alexandra-simeonova
requested review from
maxmarkus,
pekura,
JohannesDoberer,
zarkosimic and
marynaKhromova
alexandra-simeonova
requested review from
bszwarc,
kazydek,
mmitoraj and
tomekpapiernik
as code owners
alexandra-simeonova
force-pushed
the
improve-authorization-doc
branch
from
a4d80d9 to
46b37a5
Compare
|
|
||
| You have the following authorization options: | ||
| * [OpenID Connect](#openid-connect-configuration) | ||
| * [Third-party cookies and silent token refresh](#third-party-cookies-and-silent-token-refresh) |
There was a problem hiding this comment.
| * [Third-party cookies and silent token refresh](#third-party-cookies-and-silent-token-refresh) | |
| * [Third-party cookies and silent token refresh](#third-party-cookies-and-silent-token-refresh) |
Is this indentation intentional?
There was a problem hiding this comment.
It is, because that's supposed to be a sub-category of OpenID connect (that's also why its heading begins with ### instead of ##)
There was a problem hiding this comment.
Oh, right. Please ignore it then :)
docs/authorization-configuration.md
Outdated
| @@ -87,11 +107,11 @@ auth: { | |||
| - **expirationCheckInterval** the number of seconds to pass between each check if the token is about to expire. The default value is `5` seconds. | |||
|
|
|||
|
|
|||
| ### Custom Authentication Provider | |||
| ## Another authorization provider | |||
There was a problem hiding this comment.
Why the switch from Custom to Another? I think another (or, alternatively, (a) different) sounds better, as another might give an impression as if there were more than one in use at the same time. What is more, you still use the word custom and it's used in code (see lines 115, 143) so I'd stick with custom for consistency's sake if it's all the same.
(Applies also to line 112.)
There was a problem hiding this comment.
You're right, I changed it 👍
Co-Authored-By: majakurcius <[email protected]>
Co-Authored-By: majakurcius <[email protected]>
Co-Authored-By: majakurcius <[email protected]>
Co-Authored-By: majakurcius <[email protected]>
docs/authorization-configuration.md
Outdated
|
|
||
| If you are using any authentication provider you can also implement the following functions for Luigi. | ||
| If you use a custom authorization provider, you can also implement these functions for Luigi. |
There was a problem hiding this comment.
| If you use a custom authorization provider, you can also implement these functions for Luigi. | |
| If you use a custom authorization provider, you can also implement these functions for Luigi: |
Description
Changes proposed in this pull request:
Related issue(s)
#865