Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and describe "allowRules" in the general settings #881

Conversation

zarkosimic
Copy link
Contributor

Changes proposed in this pull request:

  • Add allowRules to the example in the general settings
  • Add a description for allowRules

@zarkosimic zarkosimic added the documentation documentation tasks label Oct 9, 2019
@zarkosimic zarkosimic added this to the Sprint 6 milestone Oct 9, 2019
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 (but maybe we could highlight the allow attribute instead of quotes?)

@alexandra-simeonova alexandra-simeonova self-assigned this Oct 10, 2019
docs/general-settings.md Outdated Show resolved Hide resolved
Co-Authored-By: Alexandra Simeonova <[email protected]>
Copy link
Contributor

@marynaKhromova marynaKhromova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@JohannesDoberer JohannesDoberer modified the milestones: Sprint 6, Sprint 7 Oct 14, 2019
@alexandra-simeonova alexandra-simeonova merged commit bdbd16d into SAP:master Oct 16, 2019
@zarkosimic zarkosimic deleted the 879_add_and_describe_allowRules_in_the_general_settings branch November 8, 2019 12:37
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants