Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix authSuccessfull execution on each page refresh #89

Merged
merged 7 commits into from
Sep 20, 2018
Merged

Fix authSuccessfull execution on each page refresh #89

merged 7 commits into from
Sep 20, 2018

Conversation

dariadomagala-sap
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Fix authSuccessfull execution on each page refresh

@dariadomagala-sap dariadomagala-sap added area/luigi bug Something isn't working labels Sep 17, 2018
@kwiatekus kwiatekus added the WIP Work in progress label Sep 17, 2018
@kwiatekus
Copy link
Contributor

We should rename the event handlers, as they might be confusing for the user.
Because actually the intention was to call it every time the auth data was read and validated ("the user is authenticated"). Include @hardl & beta users

@kwiatekus kwiatekus removed the WIP Work in progress label Sep 18, 2018
@kwiatekus
Copy link
Contributor

We agreed that this event should be triggered only after successful authentication (not after page reload)

@jesusreal jesusreal self-assigned this Sep 19, 2018
@dariadomagala-sap dariadomagala-sap requested a review from a user September 19, 2018 14:20
@CLAassistant
Copy link

CLAassistant commented Sep 19, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

maxmarkus
maxmarkus approved these changes Sep 20, 2018
View reviewed changes
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwiatekus kwiatekus merged commit 9f9d210 into SAP:master Sep 20, 2018
@dariadomagala-sap dariadomagala-sap deleted the oauthsuccessfull-on-each-refresh branch October 30, 2018 07:43
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@dariadomagala-sap @kwiatekus
Fix authSuccessfull execution on each page refresh (SAP#89)
2e81217 
* Fix authsuccessfull execution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxmarkus maxmarkus maxmarkus approved these changes

@antiheld antiheld Awaiting requested review from antiheld

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@jesusreal jesusreal Awaiting requested review from jesusreal

@kwiatekus kwiatekus Awaiting requested review from kwiatekus

@pekura pekura Awaiting requested review from pekura

@y-kkamil y-kkamil Awaiting requested review from y-kkamil

@kazydek kazydek Awaiting requested review from kazydek

@klaudiagrz klaudiagrz Awaiting requested review from klaudiagrz

@tomekpapiernik tomekpapiernik Awaiting requested review from tomekpapiernik

Assignees

@jesusreal jesusreal

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dariadomagala-sap @kwiatekus @CLAassistant @maxmarkus @jesusreal