-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hook at micro frontend container creation #894
Add hook at micro frontend container creation #894
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great 👍 I added some very minor changes. Reason: all the other bullet points in general-settings.md
are structured as full sentences ending with a period.
Co-Authored-By: Alexandra Simeonova <[email protected]>
Co-Authored-By: Alexandra Simeonova <[email protected]>
Co-Authored-By: Alexandra Simeonova <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, well done! 👍
I just left one comment about documentation. But feel free to ignore it if you do not agree with it :)
Co-Authored-By: Alexandra Simeonova <[email protected]>
Co-Authored-By: Alexandra Simeonova <[email protected]>
No description provided.