Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook at micro frontend container creation #894

Merged

Conversation

pekura
Copy link
Contributor

@pekura pekura commented Oct 15, 2019

No description provided.

@alexandra-simeonova alexandra-simeonova self-assigned this Oct 16, 2019
@marynaKhromova marynaKhromova self-assigned this Oct 16, 2019
Copy link
Contributor

@alexandra-simeonova alexandra-simeonova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great 👍 I added some very minor changes. Reason: all the other bullet points in general-settings.md are structured as full sentences ending with a period.

docs/general-settings.md Outdated Show resolved Hide resolved
docs/general-settings.md Outdated Show resolved Hide resolved
docs/general-settings.md Outdated Show resolved Hide resolved
Copy link
Contributor

@marynaKhromova marynaKhromova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, well done! 👍

I just left one comment about documentation. But feel free to ignore it if you do not agree with it :)

docs/general-settings.md Show resolved Hide resolved
@pekura pekura merged commit fa5b0d7 into SAP:master Oct 21, 2019
@pekura pekura deleted the Add-hook-at-micro-frontend-container-creation branch October 21, 2019 09:47
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants