Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inactive lifecycle hook #901

Merged
merged 41 commits into from
Oct 31, 2019
Merged

Conversation

maxmarkus
Copy link
Contributor

Adds addInactiveListener and removeInactiveListener to client api for receiving notification upon micro frontend inactivity.

A listener is already in the Angular example. It can be tested by using preserveView linkManager feature and by clicking to and from a viewGrouped navigation item (Settings gear icon).

@maxmarkus maxmarkus added the enhancement New feature or request label Oct 17, 2019
Copy link
Contributor

@zarkosimic zarkosimic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@zarkosimic zarkosimic self-assigned this Oct 21, 2019
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@maxmarkus maxmarkus merged commit c3b7514 into SAP:master Oct 31, 2019
@maxmarkus maxmarkus deleted the 886-inactive-lifecycle-hook branch October 31, 2019 11:07
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants