categories for documentation #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandra-simeonova
requested review from
bszwarc,
kazydek,
mmitoraj and
tomekpapiernik
as code owners
alexandra-simeonova
changed the title
alexandra-simeonova
requested review from
hardl,
jesusreal,
JohannesDoberer,
marynaKhromova,
maxmarkus,
pekura and
zarkosimic
as code owners
maxmarkus
suggested changes
Oct 28, 2019
docs/navigation-advanced.md
Outdated
|
|
||
| The view groups feature also offers out-of-the-box caching. Each time you navigate to another view group, either a new iframe is created or it is reused if already exists. In both cases, the iframe you are navigating from becomes hidden and is available for you to use again. If you navigate back to the first iframe and it should be updated with new data, such when a new entry was added in the second iframe and you want to display it in a table in the first iframe, you must define a **preloadUrl** parameter for the view group under **navigation.viewGroupSettings**. | ||
|
|
||
| You can also preload view groups. You just need to define which URL you want to preload, and Luigi will preload the view after some user interactions when the browser is most likely to be idle. This option is active by default, but you can deactivate it with a [configuration flag](navigation-parameters-reference.md#node-parameters). |
There was a problem hiding this comment.
We should show name the configuration flag here, else the user has no clue which configuration flag we are talking about. I also am not 100% sure, maybe it is preloadViewUrl (bool) in /navigation-parameters-reference.md#node-navigation-parameters?
There was a problem hiding this comment.
Thank you for the comment! I think the configuration flag for this is preloadViewGroup, so I changed the doc.
marynaKhromova
suggested changes
Oct 29, 2019
alexandra-simeonova
force-pushed
the
documentation-categories
branch
from
91ece33 to
12fa0f6
Compare
marynaKhromova
approved these changes
Oct 31, 2019
JohannesDoberer
approved these changes
Nov 4, 2019
bszwarc
suggested changes
Nov 4, 2019
docs/README.md
Outdated
|
|
||
| ## Luigi Client | ||
| > **TIP:** The [Luigi Fiddle](https://fiddle.luigi-project.io) allows you to configure a very simple application and get a feel for the process. |
There was a problem hiding this comment.
Is it the Luigi Fiddle or just Luigi Fiddle - both may be correct, so just asking :)
There was a problem hiding this comment.
Normally it's Luigi Fiddle or the Luigi Fiddle page/website, so you're right 😄
docs/navigation-advanced.md
Outdated
| This document shows you how to configure the following Luigi features: | ||
|
|
||
| * [View groups](#view-groups) | ||
| * [Create a dynamically changeable path](#create-a-dynamic-path) |
There was a problem hiding this comment.
I'm wondering if we can switch it to just Dynamic paths - to make the points match.
docs/navigation-advanced.md
Outdated
Comment on lines
21
to
22
| 1. Define the **viewGroup** parameter for any navigation node. | ||
| 2. Children of that node will automatically be considered part of the same view group. |
There was a problem hiding this comment.
I think these two do not go well with the introductory line - the first one starting with define is fine :) but the second one is not a step. I think maybe it's better to have it in one sentence?
There was a problem hiding this comment.
Agreed! 🙂
Co-Authored-By: Barbara Szwarc <[email protected]>
Co-Authored-By: Barbara Szwarc <[email protected]>
Co-Authored-By: Barbara Szwarc <[email protected]>
Co-Authored-By: Barbara Szwarc <[email protected]>
Co-Authored-By: Barbara Szwarc <[email protected]>
Co-Authored-By: Barbara Szwarc <[email protected]>
Co-Authored-By: Barbara Szwarc <[email protected]>
Co-Authored-By: Barbara Szwarc <[email protected]>
Co-Authored-By: Barbara Szwarc <[email protected]>
Co-Authored-By: Barbara Szwarc <[email protected]>
Co-Authored-By: Barbara Szwarc <[email protected]>
Co-Authored-By: Barbara Szwarc <[email protected]>
…nova/luigi into documentation-categories
bszwarc
approved these changes
Nov 5, 2019
Merged
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#766, #906