Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backdrop not covering splitview micro frontend #916

Merged
merged 5 commits into from
Oct 25, 2019
Merged

Backdrop not covering splitview micro frontend #916

merged 5 commits into from
Oct 25, 2019

Conversation

pekura
Copy link
Contributor

@pekura pekura commented Oct 22, 2019

No description provided.

@pekura pekura added the bug Something isn't working label Oct 22, 2019
@pekura pekura added this to the Sprint 7 milestone Oct 22, 2019
@zarkosimic zarkosimic self-assigned this Oct 23, 2019
zarkosimic
zarkosimic approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@zarkosimic zarkosimic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@JohannesDoberer JohannesDoberer self-assigned this Oct 23, 2019
JohannesDoberer
JohannesDoberer approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subber Sach 👍 !

@pekura pekura merged commit f7f9794 into SAP:master Oct 25, 2019
@pekura pekura deleted the Backdrop-not-covering-splitview-micro-frontend branch October 25, 2019 09:37
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@pekura
Backdrop not covering splitview micro frontend (SAP#916)
8f05ff6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@zarkosimic zarkosimic zarkosimic approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@jesusreal jesusreal Awaiting requested review from jesusreal

@marynaKhromova marynaKhromova Awaiting requested review from marynaKhromova

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

Assignees

@JohannesDoberer JohannesDoberer

@zarkosimic zarkosimic

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint 7
Development

Successfully merging this pull request may close these issues.
3 participants
@pekura @JohannesDoberer @zarkosimic