Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid auth provider error handling #920

Conversation

JohannesDoberer
Copy link
Contributor

No description provided.

Copy link
Contributor

@zarkosimic zarkosimic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@@ -36,3 +37,4 @@ You can disable the default behavior of `onAuthExpired` and `onAuthError` by mak
- `onLogout` **[function](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Statements/function)** is executed after the user logs out.
- `onAuthExpireSoon` **[function](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Statements/function)** is executed before the token expires. For OAuth2 and OIDC you can set the **accessTokenExpiringNotificationTime** to specify the number of seconds required to pass before the event is fired. The default value is `60` seconds.
- by using oAuth2ImplicitGrant you can specify **expirationCheckInterval** which is the number of seconds to pass between each check if the token is about to expire. The default value is `5` seconds.
- `onAuthConfigError` **[function](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Statements/function)** is executed if an auth provider is wrong configured and as a result not available.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `onAuthConfigError` **[function](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Statements/function)** is executed if an auth provider is wrong configured and as a result not available.
- `onAuthConfigError` **[function](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Statements/function)** is executed if an authentication provider is wrongly configured and unavailable as a result.

Copy link
Contributor

@alexandra-simeonova alexandra-simeonova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@alexandra-simeonova alexandra-simeonova self-assigned this Oct 24, 2019
@marynaKhromova marynaKhromova self-assigned this Oct 24, 2019
Copy link
Contributor

@marynaKhromova marynaKhromova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@JohannesDoberer JohannesDoberer merged commit 261442a into SAP:master Oct 25, 2019
@JohannesDoberer JohannesDoberer deleted the invalid-auth-provider-error-handling branch October 25, 2019 09:21
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants