Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide possibility to add alt attribute to the <img> tag #925

Merged
merged 11 commits into from
Oct 30, 2019
Merged

provide possibility to add alt attribute to the <img> tag #925

merged 11 commits into from
Oct 30, 2019
+205 −80

Conversation

marynaKhromova
Copy link
Contributor

@marynaKhromova marynaKhromova commented Oct 24, 2019 •
edited
Loading

Changes proposed in this pull request:

  • add alt attribute to the logo
  • add alt attribute to the img tags in top and left navigation
  • fix for the height of a product swither icon when it's
  • a small html fix for product switcher on mobile
  • docu changes

@marynaKhromova marynaKhromova added the enhancement New feature or request label Oct 24, 2019
@marynaKhromova marynaKhromova added this to the Sprint 7 milestone Oct 24, 2019
@marynaKhromova marynaKhromova added the documentation documentation tasks label Oct 24, 2019
@zarkosimic zarkosimic self-assigned this Oct 28, 2019
alexandra-simeonova
alexandra-simeonova approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@alexandra-simeonova alexandra-simeonova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@alexandra-simeonova alexandra-simeonova self-assigned this Oct 28, 2019
zarkosimic
zarkosimic approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@zarkosimic zarkosimic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@pekura pekura self-assigned this Oct 29, 2019
pekura
pekura suggested changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@pekura pekura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found couple of places where the alt attribute is missing or not working. I created a patch for those places:

patch.diff.zip

Please take a look and apply if you agree. Thank you!

@marynaKhromova
Copy link
Contributor Author

I found couple of places where the alt attribute is missing or not working. I created a patch for those places:

patch.diff.zip

Please take a look and apply if you agree. Thank you!

Thank you, Peter! really good one 👍 the changes are done.

@marynaKhromova
Merge remote-tracking branch 'upstream/master' into provide-possibilt…
4c47a40 
…y-to-add-alt-attribute-to-img-tag

# Conflicts:
#	docs/navigation-parameters-reference.md
@marynaKhromova
add AltText description
47498f5
@marynaKhromova marynaKhromova merged commit 70a1900 into SAP:master Oct 30, 2019
@marynaKhromova marynaKhromova deleted the provide-possibilty-to-add-alt-attribute-to-img-tag branch October 30, 2019 10:49
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@marynaKhromova
provide possibility to add alt attribute to the <img> tag (SAP#925)
8d8e418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pekura pekura pekura approved these changes

@zarkosimic zarkosimic zarkosimic approved these changes

@alexandra-simeonova alexandra-simeonova alexandra-simeonova approved these changes

@bszwarc bszwarc Awaiting requested review from bszwarc

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@jesusreal jesusreal Awaiting requested review from jesusreal

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer JohannesDoberer is a code owner

@kazydek kazydek Awaiting requested review from kazydek

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@mmitoraj mmitoraj Awaiting requested review from mmitoraj

@tomekpapiernik tomekpapiernik Awaiting requested review from tomekpapiernik

Assignees

@pekura pekura

@zarkosimic zarkosimic

@alexandra-simeonova alexandra-simeonova

Labels
documentation documentation tasks enhancement New feature or request
Projects
None yet
Milestone
Sprint 7
Development

Successfully merging this pull request may close these issues.
4 participants
@marynaKhromova @pekura @zarkosimic @alexandra-simeonova