Edge browser back #992
Merged
Edge browser back #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxmarkus
requested review from
hardl,
JohannesDoberer,
marynaKhromova,
pekura and
zarkosimic
as code owners
pekura
reviewed
Nov 28, 2019
core/package.json
Outdated
| @@ -52,7 +52,7 @@ | |||
| "bundle-ie11": "webpack --mode=production --display-error-details --config webpack-ie11.config.js", | |||
| "bundle-develop": "npm run bundle-develop-evergreen", | |||
| "bundle-develop-evergreen": "npm run bundle-evergreen -- -d --watch", | |||
| "bundle-develop-ie11": "webpack --display-error-details --config webpack-ie11.config.js --debug --devtool cheap-source-map --output-pathinfo --watch", | |||
| "bundle-develop-ie11": "MINIFY=false webpack --display-error-details --config webpack-ie11.config.js --debug --devtool source-map --output-pathinfo --watch", | |||
There was a problem hiding this comment.
I think this won‘t work for ie11 as the non-cheap source-map uses eval and the code in the eval block is not transpiled.
pekura
approved these changes
Nov 28, 2019
JohannesDoberer
approved these changes
Nov 29, 2019
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Nov 29, 2019
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Dec 4, 2019
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes browser back issue in MS Edge and IE11.