Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor patch #43

Merged
merged 18 commits into from
Jul 29, 2022
Merged

Minor patch #43

merged 18 commits into from
Jul 29, 2022

Conversation

KaraMelih
Copy link
Collaborator

I made some necessary changes;

  • auth instance is passed around but was not an argument of the function. I added that as an optional argument so it is more flexible. (And is a must for xenon to manually pass hop.Auth() instance)
  • I added a "testing" key to the messages submitted within scenarios, so that CS can look for this key and bypass neutrino-from-future check.
  • I added a way of checking the user's experiment ONLY ONCE in the first time they execute any script. It prompts the list of experiment, user enters the index and from then on the detector name is always what they chose. (Can always be changed afterwards from the env file, but one needs to find it)
  • I added an (amazing) connection checker. It opens two streams one for subscribing one for publishing. It publishes a message with "_id=test-connection" and with current time, with status "sending", and waits. CS sees this messages, submits the same message only changing the status to "received", and the subscribed stream sees this match, confirms connection.

@KaraMelih
Copy link
Collaborator Author

tests are failing because of this initial one-time-only input request. @joesmolsky is there a way to select one number in the tests?

@Storreslara Storreslara merged commit 33dd43a into main Jul 29, 2022
@KaraMelih KaraMelih deleted the minor_patch branch July 29, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants