-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iso time #52
Iso time #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks quite good, thanks for taking care of it!
I just want to check it with pycharm to see if the TimeStuff is not used in anywhere else.
This indeed simplifies things
Your commits from yesterday started to fail the tests; |
I have updated the format checker to include warnings with the logs. Also did some fixes to the time checking logic and fixed some typos in the test function times. |
Thanks Joe it looks better! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some comments. I noticed that there are a few minor things need to be changed
You can also debug these via |
Change time format to ISO format. This makes the TimeStuff class obsolete. Times can now be set with datetime.utcnow().isoformat().
Version also changes from 1.1.0 to 1.1.1