Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete old deprecations and unused code #353

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Delete old deprecations and unused code #353

merged 4 commits into from
Aug 14, 2024

Conversation

JostMigenda
Copy link
Member

Removes a lot of deprecated code from the early days of snewpy v1.x and closes #225.

This should all be uncontroversial stuff. I’ll put the changes to individual SupernovaModel child classes into a separate PR later today, since there may be a few questions to discuss there.

@JostMigenda JostMigenda added this to the v2.0 milestone Aug 13, 2024
@JostMigenda JostMigenda requested a review from sybenzvi August 13, 2024 17:26
@JostMigenda
Copy link
Member Author

Integration test failures are due to get_transformed_spectra still using the old transformations; this same failure is also present on the release_v2.0 branch, so shouldn’t stop us from reviewing/merging this PR.

@JostMigenda JostMigenda force-pushed the JostMigenda/variousDeprecations branch from 4ce739f to e20eab4 Compare August 14, 2024 03:19
@JostMigenda JostMigenda mentioned this pull request Aug 14, 2024
Merged
sybenzvi
sybenzvi approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@sybenzvi sybenzvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections, this looks like a straightforward deletion of obsolete warnings and features.

@sybenzvi sybenzvi merged commit e0553c0 into release_v2.0 Aug 14, 2024
3 of 6 checks passed
@sybenzvi sybenzvi deleted the JostMigenda/variousDeprecations branch August 14, 2024 14:51
@JostMigenda JostMigenda linked an issue Aug 14, 2024 that may be closed by this pull request
init_model convenience function #225
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sybenzvi sybenzvi sybenzvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

init_model convenience function
2 participants
@JostMigenda @sybenzvi