Suggested restructuring of snewpy.flavor_transformations submodules
#367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move transformation presets to __init__.py * move FlavorTransformation base class to base.py
Better reflects the contents of the file.
Sheshuk
approved these changes
Nov 22, 2024
JostMigenda
deleted the
JostMigenda/FlavorTransformations_suggested_restructuring
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #351 for context.
This is mostly moving existing code around; the only actual change is that I removed the special case where
TransformationChain(in_sn=None)would returnNoTransformation. This wasn’t documented in the doc string or type information anyway; and I think it’s a bit dangerous, since it would lead to unexpected results if a user triedTransformationChain(in_sn=None, in_earth=EarthMatter); so I think it’s reasonably to drop it and require users to useNoTransformationexplicitly.