SNEWPY integration #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add Transformation class (this commit mainly moves existing code to a separate class; more in a followup commit) * add CompositeFlux class to manage different flavor components
move all argument handling to separate function; delete old code
* rename noosc/normal/inverted options to be consistent with SNEWPy * add DeprecationAction to handle this smoothly * add Adapter class to use other transformations from SNEWPy (basic implementation only, not yet available from the command line)
* currently require "SNEWPY-" prefix, are not yet displayed in help text * add SNEWPY dependency with extra syntax: 'pip install sntools[snewpy]'
* currently only Nakazato_2013 model, for demonstration * currently requires "SNEWPY-" prefix, not yet displayed in help text * performance optimization still TBD
* performance improvements for SNEWPY-inherited models * remove duplicate code in several input formats
* display SNEWPY formats/transformations only if SNEWPY is installed * handle SNEWPY/native input formats outside of main function * fix exception if no --transformation argument was specified * change default --format to nakazato to match the included sample files * edit some help messages
use new --transformation argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially covers #28 and adds support for
CompleteExchange,NonAdiabaticMSWH,TwoFlavorDecoherence(NMO and IMO) andThreeFlavorDecoherenceflavor transformations andBollig_2016,Kuroda_2020,Nakazato_2013,OConnor_2015,Sukhbold_2015andZha_2021supernova modelsif SNEWPY is installed.
The following flavor transformations from SNEWPY are not yet supported:
NoTransformationandAdiabaticMSW: identical to the transformations already natively supported by sntools (in fact, the native implementations were renamed for consistency)NeutrinoDecay: has energy-dependent transformation propabilities, which requires additional changes to sntoolsAdiabaticMSWesandNonAdiabaticMSWes: requires additional input parameters (sterile mixing angles)The following supernova models from SNEWPY are not yet supported:
Fornax_2019andFornaxModel: alternative implementations of the same model; will wait until SNEWPY has decided how to move forward.Janka: inconsistent return type ofget_time(), see issue 45 on SNEWPY repo.Warren_2020: identical to the nativewarren2020input format already supported by sntools.