Added options for custom boxes, cylinders and spheres. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the last WATCHMAN study, we had a look at different detector sizes. To facilitate easy use, I have added the capability to run custom detector sizes and fills, defined from the command line. It should still perform as before for the already defined detectors. Since it was a straightforward addition, I also allowed for spherical designs, this might be useful for SNO+, for example. This might need more work to be in line with @svalder recent pull request #41 - and adjustments of the unit tests.
Please have a look and check whether this is useful. If so, let me know and I can update the documentation and unit tests accordingly.
This also replaces the closed PR #42 with the messy history.