JUNO: don’t write secondary file in verbose mode #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JostMigenda
force-pushed
the
JostMigenda/JUNOOutputFile
branch
from
bcdb2d1
to
fc46035
Compare
JostMigenda
force-pushed
the
JostMigenda/JUNOOutputFile
branch
from
fc46035
to
0e65947
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, in verbose mode sntools would write the timestamp and parameters to the filename
args.output. For NUANCE and RATPAC files, it would then write events to the same file; for JUNO, it would write them to a separate file (with an additional.rootsuffix).Since it doesn’t make much sense to have these parameters in a different file than the actual events, this PR avoids writing the parameters file.
@mcolomermolla Do you think it’s worth adding a separate tree with that metadata to the root files? (I occasionally found it useful when trying things out; for production use it’s unnecessary, since there will be other mechanisms to handle this bookkeeping.)