Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSpot should set the thread context classloader #269

Closed
vmassol opened this issue Dec 11, 2017 · 1 comment
Closed

DSpot should set the thread context classloader #269

vmassol opened this issue Dec 11, 2017 · 1 comment
Assignees
@vmassol

Comments

@vmassol
Copy link
Contributor

vmassol commented Dec 11, 2017

Right now no CL is set and thus the thread context CL is the system CL and any code in tests using the thread context CL (such as ServiceLoader) will not find the resources it needs.

FTR this was making TypeConverterTest and almost every tests in XWiki fail, since the dependency injection feature of XWiki relies on the ServiceLoader working....
@vmassol vmassol self-assigned this Dec 11, 2017
@vmassol
Copy link
Contributor Author

vmassol commented Dec 11, 2017 •
edited
Loading

See #270 (forgot the '#' symbol in my commit...)

vmassol added a commit to vmassol/dspot that referenced this issue Dec 12, 2017
@vmassol
Issue STAMP-project#269: DSpot should set the thread context classloader
9906b00 
* Add explanations
danglotb pushed a commit that referenced this issue Dec 12, 2017
@vmassol @danglotb
docs: Issue #269 DSpot should set the thread context classloader (#278)
64af74c 
* add comments to explain the `Thread.currentThread().setContextClassLoader()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vmassol vmassol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vmassol