FEAT: Add test framework package from dspot #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are on their way BTW; Who I would be if I do not provide any test? |
|
Waoow, really cool. Let's test and merge. Yeah :) |
|
@danglotb ready to merge? |
|
I'm sorry I don't have the time right now to test this. I guess that we can merge it as it is if it is blocking for @martinezmatias. I keep track of this in order to test and pursue the refactoring of DSpot when I have the chance. |
|
No problem, I propose to merge this and rebase #80 afterwards. @martinezmatias WDYT? |
|
Let's do it :) |
|
Merged thanks Benjamin. Matias, you can proceed with rebase your PR. |
|
Hi @monperrus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some part of this code is completly dedicated to DSpot. I guess that it would be great to better slice it and / or avoid any commented code.
However, in order to let @martinezmatias move forward, I suggest moving the code like this (if this works for what you have to do).
And then, I'll refactor (huge technical debts here, but I'll be on holiday some day...) the code.
For the DSpot side, there a bunch of refactoring / wrapping of the code. I'll have a look at this.
WDYT @monperrus @martinezmatias ?