Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add option to set detail of coverage information + method level instruction coverage #88

Merged

Conversation

lacinoire
Copy link
Contributor

(includes / dependent on #87)

Good afternoon 😊

For Test Cube I needed more detailed coverage information, specifically the instruction coverage reported per method.
I adapted my modifications to fit @martinezmatias new coverage transformers and added an option to specify which coverage transformer should be used.

Included a test for the new method-detailed coverage and a more general test to help me understand the comparison of two coverages.

@martinezmatias
Copy link
Contributor

Hi @lacinoire

The PR looks great to me and can be merged.
(I don't have rights to merge)
Regards
Matias

@danglotb
Copy link
Member

Looks like there are common commits with #87
Would be possible to remove them in order to split the fix/feat into two distinct pull-requests?
If not, we might close #87 and merge this one.
Thank you! 😄

@lacinoire lacinoire force-pushed the expressive-instruction-coverage branch from c5cc0fb to 7e5810b Compare March 19, 2021 15:05
@lacinoire
Copy link
Contributor Author

I cherry picked the last commit and now there are no overlaps with #87 anymore 🙂

@danglotb danglotb merged commit c84fc30 into STAMP-project:master Mar 19, 2021
@lacinoire lacinoire deleted the expressive-instruction-coverage branch July 21, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants