Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHS-5148: fix hover styles in hb-categories #1408

Merged
merged 2 commits into from
Nov 27, 2023
Merged

SHS-5148: fix hover styles in hb-categories #1408

merged 2 commits into from
Nov 27, 2023

Conversation

cienvaras
Copy link
Collaborator

@cienvaras cienvaras commented Nov 27, 2023 •
edited
Loading

READY FOR REVIEW

Summary

  • Add padding to hb-categories list item to make underline on hover visible

Need Review By (Date)

11/27

Urgency

medium

Steps to Test

  1. Visit https://hs-colorful.suhumsci.loc/default-views/people
  2. Confirm that the "Research Areas" items present in some cards have a bottom border on hover
  3. Repeat test on https://hs-traditional.suhumsci.loc/default-views/people
Screenshot 2023-11-27 at 10 28 40

PR Checklist

@cienvaras cienvaras requested a review from mndonx November 27, 2023 16:29
@cienvaras cienvaras self-assigned this Nov 27, 2023
@cienvaras cienvaras marked this pull request as ready for review November 27, 2023 16:41
mndonx
mndonx approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@mndonx mndonx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, thanks @cienvaras !

@cienvaras cienvaras merged commit 52772bb into fk-stnfd-sprint-39 Nov 27, 2023
1 check failed
@cienvaras cienvaras deleted the shs-5148-hb-categories-underline branch November 27, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mndonx mndonx mndonx approved these changes

Assignees

@cienvaras cienvaras

Labels
Needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cienvaras @mndonx