fix(shs-5150): fixing empty headings on grid views #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
This PR updates the
views-view-unformattedandviews-view-gridtemplates to check for a heading tag within title markup before printing an<h3>tag in the template.Urgency
medium
Steps to Test
Ensure there are no longer WAVE issues around empty heading tags printing on the following pages:
https://anthropology.suhumsci.loc/people/faculty-and-affiliates/faculty/leadership
https://dlcl.suhumsci.loc/people/faculty
https://shenlab.stanford.edu/people
Also check:
https://hs-traditional.suhumsci.loc/default-views/people
Please note that I have found one outlying issue that is noticeable in the traditional example. If the view returns "grouped" content, and it is grouped by a field that allows the user to select nothing, the field will print with comments inside the
<h3>. I believe this will only happen live when logged in (I'm having trouble testing that since I can see template comments logged out locally.)PR Checklist