Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS-5844: The Hover state of links on global banners doesn't meet contrast #1638

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

cienvaras
Copy link
Collaborator

@cienvaras cienvaras commented Sep 30, 2024

READY FOR REVIEW

Summary

  • Fix contrast of hover links in global message component.

Need Review By (Date)

10/09

Urgency

medium

Steps to Test

  1. Visit /admin/config/system/global-message
  2. If disabled, enable the global message. Set the "Message type" to any value (all will be tested) and add some test content if needed. Make sure to add an action link.
  3. Visit any page on the site and confirm that the default and hover state of any link in the global message match the Figma designs.
  4. Go back to the global message edit form and try all other message types. Repeat the previous test.

Note: traditional and colorful share the same global message styles, you can test on any site and the results should be the same.

PR Checklist


@cienvaras cienvaras self-assigned this Sep 30, 2024
@ahughes3 ahughes3 temporarily deployed to Tugboat September 30, 2024 00:47 Destroyed
@cienvaras
Copy link
Collaborator Author

@mariannuar Please hold on reviewing this one, we need to change the styles a bit more.

@cienvaras cienvaras removed the request for review from mariannuar October 1, 2024 18:35
Base automatically changed from 11.2.5-release to develop October 3, 2024 15:39
@cienvaras cienvaras changed the base branch from develop to 11.3.1-release October 9, 2024 22:03
@ahughes3 ahughes3 temporarily deployed to Tugboat October 9, 2024 23:10 Destroyed
@cienvaras cienvaras requested a review from mariannuar October 9, 2024 23:14
Copy link
Collaborator

@mariannuar mariannuar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cienvaras LGTM! 🚀

@cienvaras
Copy link
Collaborator Author

@ahughes3 Ready for your review.

@cienvaras cienvaras requested a review from ahughes3 October 10, 2024 15:27
@cienvaras cienvaras assigned ahughes3 and unassigned cienvaras Oct 10, 2024
Copy link
Collaborator

@ahughes3 ahughes3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@ahughes3 ahughes3 assigned joegl and unassigned ahughes3 Oct 10, 2024
@ahughes3 ahughes3 requested a review from joegl October 10, 2024 16:56
@joegl joegl merged commit 1bf58ad into 11.3.1-release Oct 11, 2024
16 of 17 checks passed
@joegl joegl deleted the shs-5844--link-hover-global-banner branch October 11, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants