Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS-5812: Remove Webform module from the codebase #1648

Merged
merged 6 commits into from
Jan 31, 2025

Conversation

cienvaras
Copy link
Collaborator

@cienvaras cienvaras commented Oct 7, 2024

Summary

Remove hs_webform and webform contrib module from codebase

Need Review By (Date)

01/29

Urgency

medium

Steps to Test

  1. Log into a tugboat test site. Visit the module list admin page (Manage > Extend in the toolbar)
  2. Search for "webform" and confirm that the custom "H&S Webform Paragraph", the webform contrib module and all its submodule are not present in the module list (Note: you'll see 2 disabled modules: "Webform Event Dispatcher" and "Token Or Webform". Those are webform integration modules provided by another contrib module and can be ignored).

Review Tasks

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Are PHP functions and variables in snake_case and not camelCase?
  • Does Drupal code follow Drupal Coding Standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided?

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

@cienvaras cienvaras self-assigned this Oct 7, 2024
@ahughes3 ahughes3 temporarily deployed to Tugboat October 7, 2024 01:22 Destroyed
@cienvaras cienvaras changed the base branch from develop to 11.3.1-release October 7, 2024 01:22
Base automatically changed from 11.3.1-release to develop October 16, 2024 15:43
@cienvaras cienvaras changed the base branch from develop to 11.6.3-release January 20, 2025 22:13
Base automatically changed from 11.6.3-release to develop January 22, 2025 16:25
@cienvaras cienvaras changed the base branch from develop to 11.6.4-release January 23, 2025 23:54
@ahughes3 ahughes3 temporarily deployed to Tugboat January 24, 2025 00:07 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat January 24, 2025 00:19 Destroyed
@cienvaras cienvaras marked this pull request as ready for review January 24, 2025 00:54
@cienvaras
Copy link
Collaborator Author

@ahughes3 Ready for your review

@cienvaras cienvaras requested a review from ahughes3 January 24, 2025 00:55
@cienvaras cienvaras assigned ahughes3 and unassigned cienvaras Jan 24, 2025
@ahughes3 ahughes3 temporarily deployed to Tugboat January 27, 2025 19:16 Destroyed
Copy link
Collaborator

@ahughes3 ahughes3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahughes3 ahughes3 requested a review from joegl January 30, 2025 17:06
@ahughes3 ahughes3 assigned joegl and unassigned ahughes3 Jan 30, 2025
@ahughes3 ahughes3 temporarily deployed to Tugboat January 31, 2025 17:33 Destroyed
@joegl joegl merged commit 3f80ab5 into 11.6.4-release Jan 31, 2025
14 of 16 checks passed
@joegl joegl deleted the shs-5812--remove-webform-module branch January 31, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants